b/gigaparsec
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Regexp: succeed on empty match at end of input

Browse Source
This commit is contained in:
Brandon Dyck 2025-04-02 14:06:12 -06:00
parent 1892a97070
commit 4e157f7a0e
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
bytes/regexp.go
View File

@ -80,7 +80,7 @@ func Regexp(pattern string) gigaparsec.Parser[byte, string] {
// when searching a RuneReader. // when searching a RuneReader.
dst := make([]byte, idx[1]-idx[0]) dst := make([]byte, idx[1]-idx[0])
n, _, err := input.Read(dst) n, _, err := input.Read(dst)
if err != nil { if err != nil && (!errors.Is(err, io.EOF) || n < uint64(len(dst))) {
return gigaparsec.Result[byte, string]{}, fmt.Errorf("Regexp: unexpected error: %w", err) return gigaparsec.Result[byte, string]{}, fmt.Errorf("Regexp: unexpected error: %w", err)
} }
next := input.At(input.Pos() + n) next := input.At(input.Pos() + n)

8
bytes/regexp_test.go
View File

@ -61,6 +61,14 @@ func TestRegexp(t *testing.T) {
must.NoError(t, err) must.NoError(t, err)
test.StrContains(t, result.Message().Got(), "hella") test.StrContains(t, result.Message().Got(), "hella")
}) })
t.Run("succeeds on empty matches", func(t *testing.T) {
p := pbytes.Regexp(".*")
result, err := p(gigaparsec.MakeState(strings.NewReader("")))
succeeded, value, _ := result.Status()
must.NoError(t, err)
must.True(t, succeeded)
must.EqOp(t, "", value)
})
} }
func TestRuneReader(t *testing.T) { func TestRuneReader(t *testing.T) {