b/gigaparsec
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Regexp: don't return error when match fails at EOF

Browse Source
This commit is contained in:
Brandon Dyck 2025-04-02 14:24:21 -06:00
parent 4e157f7a0e
commit 82ed6b5546
2 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
bytes/regexp.go
View File

@ -69,6 +69,9 @@ func Regexp(pattern string) gigaparsec.Parser[byte, string] {
return gigaparsec.Result[byte, string]{}, fmt.Errorf("Regexp: reader error: %w", err) return gigaparsec.Result[byte, string]{}, fmt.Errorf("Regexp: reader error: %w", err)
} }
if idx == nil { if idx == nil {
if err == io.EOF {
return gigaparsec.Fail[byte, string](false, gigaparsec.MessageEnd(input.Pos())), nil
}
got := make([]byte, r.Count()) got := make([]byte, r.Count())
_, _, err = input.Read(got) _, _, err = input.Read(got)
if err != nil { if err != nil {

7
bytes/regexp_test.go
View File

@ -69,6 +69,13 @@ func TestRegexp(t *testing.T) {
must.True(t, succeeded) must.True(t, succeeded)
must.EqOp(t, "", value) must.EqOp(t, "", value)
}) })
t.Run("fails without an error at EOF", func(t *testing.T) {
p := pbytes.Regexp("a")
result, err := p(gigaparsec.MakeState(strings.NewReader("")))
succeeded, _, _ := result.Status()
must.NoError(t, err)
must.False(t, succeeded)
})
} }
func TestRuneReader(t *testing.T) { func TestRuneReader(t *testing.T) {