From e37a792176deb89f17c4346d79f90c6ff58b146d Mon Sep 17 00:00:00 2001 From: Brandon Dyck Date: Sun, 27 Nov 2022 12:02:24 -0700 Subject: [PATCH] Updated todo items --- ph7.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ph7.go b/ph7.go index 20c4f37..53ebe00 100644 --- a/ph7.go +++ b/ph7.go @@ -270,7 +270,7 @@ type Value C.ph7_value // TODO (*Value).IsResource // TODO (*Value).IsEmpty -// TODO Init +// ph7_lib_init is unnecessary when single-threaded, and possibly always. // TODO Config // TODO Shutdown // TODO IsThreadsafe @@ -354,6 +354,7 @@ type ForeignFunction interface { //export call_foreign_function func call_foreign_function(ctx *C.ph7_context, argc C.int, argv **C.ph7_value) C.int { fkey := C.ph7_context_user_data(ctx) + // TODO it looks like ph7 looks for a VFS at the user data pointer. WTF? Should we use it for that? f := pointer.Restore(fkey).(ForeignFunction) args := make([]*Value, 0, argc) argvSlice := unsafe.Slice(argv, argc)